Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] i386: add command line option "local_apic_timer_c2_ok" | Date | Fri, 30 Mar 2007 00:06:22 +0200 |
| |
On Thursday 29 March 2007 23:45, Andreas Mohr wrote: > Hi, > > On Thu, Mar 29, 2007 at 02:16:54PM -0700, Linus Torvalds wrote: > > > > > > On Thu, 29 Mar 2007, Andi Kleen wrote: > > > > > > Here's a patch. I don't have a system with C1E, so i only tested that > > > the apic timer still works on a older AMD box. > > > > I think this looks better than what we have now, but it would look even > > better if the core CPUID stuff was in arch/i386/kernel/cpu/amd.c, and we > > simply had X86_FEATURE_BROKEN_C1_LAPIC etc.. > > Please don't, this would break the interface logically.
We already have several of those. And negative is much easier.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |