Messages in this thread |  | | | From | (Eric W. Biederman) | | Subject | Re: [PATCH 14/21] MSI: Use a list instead of the custom link structure | | Date | Wed, 28 Mar 2007 23:24:00 -0600 |
| |
Michael Ellerman <michael@ellerman.id.au> writes:
> > I thought about doing it in the MSI enable methods, but I think it > really belongs in the (nonexistant) routine that allocs and sets up a > pci_dev.
I agree that would be a good place for it as well.
> I think it's pretty dicy to be passing around a pci_dev with an > uninitialised msi_list. Even if currently no code outside the MSI enable > methods looks at it, I think we're asking for bugs in the future.
Reasonable.
> So I'll do a patch which adds alloc_pci_dev(), update the callers, and > then put the msi_list initialisation in there.
Sounds good. That will allow us to initialize all of the fields in struct pci_dev to a default value in one place.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |