Messages in this thread | | | Subject | Re: [PATCH] Add support for deferrable timers (respun) | From | Andi Kleen <> | Date | 28 Mar 2007 13:06:35 +0200 |
| |
Venki Pallipadi <venkatesh.pallipadi@intel.com> writes: > +++ new/kernel/timer.c 2007-03-26 15:19:35.000000000 -0800 > @@ -74,7 +74,7 @@ > tvec_t tv3; > tvec_t tv4; > tvec_t tv5; > -} ____cacheline_aligned_in_smp; > +} ____cacheline_aligned;
Why this change? It should be aligned to 2 bytes anyways.
> static DEFINE_PER_CPU(tvec_base_t *, tvec_bases) = &boot_tvec_bases; > > +/* > + * The lowest bit of base ptr in timer is used as a flag to indicate > + * 'deferrable' nature of the timer. Functions below help us manage that flag. > + */ > +static inline unsigned int tbase_get_deferrable(struct tvec_t_base_s *base) > +{ > + return ((unsigned int)base & TBASE_DEFERRABLE_FLAG);
This will warn on 64bit for cast ptr -> int
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |