Messages in this thread |  | | | Date | Wed, 28 Mar 2007 13:38:53 +0530 | | From | Vivek Goyal <> | | Subject | Re: [PATCH] kdump/kexec: calculate note size at compile time |
| |
On Wed, Mar 28, 2007 at 04:13:20PM +0900, Horms wrote: [..] > > DESC is probably a better name that BODY here, I meant to update > that before posting. An updated version is below. > > > > +#define KEXEC_NOTE_BYTES ( (KEXEC_NOTE_HEAD_BYTES * 2) + \ > > > > Why are we multiplying KEXEC_NOTE_HEAD_BYTES with 2? > > The way that the note merging code works in vmcore it assumes that > the area is a list of notes. And there is a terminating note that > has all the header values set to 0, and nothing else. So the time 2 > is for the space to store the terminating note. >
Ok.. Got it. Looks fine to me.
Thanks Vivek - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |