lkml.org 
[lkml]   [2007]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 12/21] MSI: Leave MSI-X masking to the irq chip
    Date
    Michael Ellerman <michael@ellerman.id.au> writes:

    > When freeing an MSI-X in msi_free_irq(), the irq must have already been
    > free'd (otherwise we'd hit the BUG_ON), and in the process will have been
    > masked or otherwise disabled by the irq chip methods. So there's no
    > reason to mask again in the MSI code.

    Given the recent discussion about the problems of lazy disable I don't believe
    the premise of this patch.

    Although I suspect the proper solution is to fix free_irq to call ->mask instead
    of disable. If an irq fires in the forest and no one is listening who cares.

    After which point this patch would make sense again.

    Eric
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-28 08:07    [W:0.020 / U:33.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site