lkml.org 
[lkml]   [2007]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 2.6.21-rc5] MSI: read-flush MSI-X table
Date
From
Eric W. Biederman wrote:

>> However the mask function is called at EVERY interrupt,
>> so this change would be VERY expensive.
>
>If true I think that would be bad. However I don't see it.
>Where in handle_edge_irq do we mask the interrupt?
>The only place I see us calling ->mask is from move_native_irq
>and that only if IRQ_MOVE_PENDING is true.
>
>All I can see is us routinely calling is ack_APIC_edge.

Doh! I was reading the code wrong. We only mask if we're still
handling a previous interrupt on the same vector. My bad.

However, I can't really see where mask() is used outside of that
instance. Which then leads us back to the question: do we need
a read flush on mask/unmask or just enable/disable?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-27 23:47    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site