Messages in this thread Patch in this message | | | Date | Mon, 26 Mar 2007 16:56:30 -0300 | From | "Luiz Fernando N. Capitulino" <> | Subject | Re: [PATCH] USB Elan FTDI: check for driver registration status |
| |
Em Mon, 26 Mar 2007 23:33:12 +0400 Cyrill Gorcunov <gorcunov@gmail.com> escreveu:
| if usb registration failed we should release all worqueues we've | created and that is the reason why I've changed the code...
I see, maybe something like the following (not tested):
diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c index bc3327e..cf95ae8 100644 --- a/drivers/usb/misc/ftdi-elan.c +++ b/drivers/usb/misc/ftdi-elan.c @@ -2903,7 +2903,8 @@ static struct usb_driver ftdi_elan_drive }; static int __init ftdi_elan_init(void) { - int result; + int result = -ENOMEM; + printk(KERN_INFO "driver %s built at %s on %s\n", ftdi_elan_driver.name, __TIME__, __DATE__); init_MUTEX(&ftdi_module_lock); @@ -2918,9 +2919,13 @@ static int __init ftdi_elan_init(void) if (!respond_queue) goto err3; result = usb_register(&ftdi_elan_driver); - if (result) + if (result) { printk(KERN_ERR "usb_register failed. Error number %d\n", result); + destroy_workqueue(respond_queue); + goto err3; + } + return result; err3: @@ -2929,7 +2934,7 @@ static int __init ftdi_elan_init(void) destroy_workqueue(status_queue); err1: printk(KERN_ERR "%s couldn't create workqueue\n", ftdi_elan_driver.name); - return -ENOMEM; + return result; } static void __exit ftdi_elan_exit(void) PS: Please, don't remove people from the CC list (wait for them to ask for that).
-- Luiz Fernando N. Capitulino - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |