Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: [PATCH 17/21] MSI: Clear the irq_desc's msi pointer on free | Date | Sun, 25 Mar 2007 21:07:31 -0600 |
| |
Michael Ellerman <michael@ellerman.id.au> writes:
> We don't call dynamic_irq_cleanup(), so it never gets done. Perhaps we > should be using your dynamic_irq_init/cleanup.
It depends. If you are going through another irq controller etc. dynamic_irq_cleanup is probably excessive.
>> Therefore you are doing this too late and we need to ensure the >> architecture code does this in arch_teardown_msi_irq. > > As long as the arch teardown routine somehow calls dynamic_irq_cleanup() > it should be fine. But I guess it's probably safer to just have all > archs do set_msi_irq(irq, NULL) in the teardown.
Yes. That sounds correct.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |