lkml.org 
[lkml]   [2007]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[-mm patch] fs/revoke.c: cleanups (and bugfix for 64bit systems)
On Mon, Mar 19, 2007 at 08:56:23PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.21-rc3-mm1:
>...
> +revoke-core-code.patch
>...
> revoke() syscall
>...


This patch contains the following:
- every file should #include the headers containing the prototypes for
it's global functions
- fix the wrong return value of sys_frevoke() gcc was now able to detect
- make 2 needlessly global structs static

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---
fs/revoke.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.21-rc4-mm1/fs/revoke.c.old 2007-03-23 23:31:46.000000000 +0100
+++ linux-2.6.21-rc4-mm1/fs/revoke.c 2007-03-23 23:50:39.000000000 +0100
@@ -16,6 +16,7 @@
#include <linux/mount.h>
#include <linux/sched.h>
#include <linux/revoked_fs_i.h>
+#include <linux/syscalls.h>

/*
* This is used for pre-allocating an array of file pointers so that we don't
@@ -28,7 +29,7 @@
unsigned long restore_start;
};

-struct kmem_cache *revokefs_inode_cache;
+static struct kmem_cache *revokefs_inode_cache;

/*
* Revoked file descriptors point to inodes in the revokefs filesystem.
@@ -551,7 +552,7 @@
return err;
}

-asmlinkage int sys_frevoke(unsigned int fd)
+asmlinkage long sys_frevoke(unsigned int fd)
{
struct file *file = fget(fd);
int err = -EBADF;
@@ -618,7 +619,7 @@
REVOKEFS_MAGIC, mnt);
}

-struct file_system_type revokefs_fs_type = {
+static struct file_system_type revokefs_fs_type = {
.name = "revokefs",
.get_sb = revokefs_get_sb,
.kill_sb = kill_anon_super
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-24 14:11    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site