Messages in this thread | | | Date | Sat, 24 Mar 2007 01:06:28 +0100 (MET) | From | Jan Engelhardt <> | Subject | Re: [patch 1/2] hugetlb: add resv argument to hugetlb_file_setup |
| |
On Mar 23 2007 15:53, Ken Chen wrote: > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 8c718a3..981886f 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -734,7 +734,7 @@ static int can_do_hugetlb_shm(void) > can_do_mlock()); > } > > -struct file *hugetlb_zero_setup(size_t size) > +struct file *hugetlb_file_setup(size_t size, int resv) > { > int error = -ENOMEM; > struct file *file; > @@ -771,7 +771,7 @@ struct file *hugetlb_zero_setup(size_t s > goto out_file; > > error = -ENOMEM; > - if (hugetlb_reserve_pages(inode, 0, size >> HPAGE_SHIFT)) > + if (resv && hugetlb_reserve_pages(inode, 0, size >> HPAGE_SHIFT)) > goto out_inode; > > d_instantiate(dentry, inode);
Could not this be made a bool, then?
Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |