Messages in this thread | | | Date | Fri, 23 Mar 2007 15:04:33 -0700 | From | "Ken Chen" <> | Subject | Re: [patch] rfc: introduce /dev/hugetlb |
| |
On 3/23/07, William Lee Irwin III <wli@holomorphy.com> wrote: > On Fri, 23 Mar 2007, William Lee Irwin III wrote: > >> Lack of compiletesting beyond x86-64 in all probability. > > On Fri, Mar 23, 2007 at 03:15:55PM +0000, Mel Gorman wrote: > > Ok, this will go kablamo on Power then even if it compiles. I don't > > consider it a fundamental problem though. For the purposes of an RFC, it's > > grand and something that can be worked with. > > He needs to un-#ifdef the prototype (which he already does), but he > needs to leave the definition under #ifdef while removing the static > qualifier. A relatively minor fixup.
Yes, sorry about that for lack of access to non-x86-64 machines. I needed to move the function prototype to hugetlb.h and evidently removed the #ifdef by mistake. I'm not going to touch this in my next clean up patch, instead I will just declare char specific file_operations struct in hugetlbfs and then have char device reference it.
But nevertheless, hugetlb_get_unmapped_area function prototype better be in a header file somewhere.
- Ken - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |