lkml.org 
[lkml]   [2007]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: request_queue_t depends on CONFIG_BLOCK
    Date

    Hi,

    On Friday 23 March 2007, Olaf Hering wrote:
    > On Thu, Mar 22, Christoph Hellwig wrote:
    >
    > > On Thu, Mar 22, 2007 at 10:52:34PM +0100, Olaf Hering wrote:
    > > > How can this compile error be fixed properly?
    > > > request_queue_t is inside CONFIG_BLOCK,
    > > > ide_drive_s (and likely others) use it unconditionally.
    > > >
    > > >
    > > > CC arch/powerpc/kernel/setup_64.o
    > > > In file included from linux-2.6.21-rc4/arch/powerpc/kernel/setup_64.c:23:
    > >
    > > start looking for the problem here. Why does you arch code include ide.h?
    >
    > Because it is needed in a few places.

    Is there really any PPC64 specific code which needs <linux/ide.h>
    (ppc_ide_md is used only by PPC32)?

    > Better hide everything in ide.h inside #ifdef CONFIG_IDE

    <linux/ide.h> is _stricly_ for IDE subsystem, please fix PPC64 code instead

    Thanks,
    Bart
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-23 19:25    [W:0.022 / U:0.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site