lkml.org 
[lkml]   [2007]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm try#2] Blackfin: architecture update patch
    On Fri, Mar 23, 2007 at 02:04:30PM +0800, Wu, Bryan wrote:
    > This is the latest blackfin update patch. Because there are lots of
    > issue fixing in this one, I put all modification in one update patch
    > which is located in:
    > https://blackfin.uclinux.org/gf/download/frsrelease/39/2707/blackfin-arch-2.6.21-rc4-mm1-update.patch
    >
    I hope these will split up logically in the future so it's possible to
    reply to them without having to do manual mangling..

    The patch generally looks fine, this is the only thing that really jumped
    out:

    > Index: linux-2.6/include/asm-blackfin/pgtable.h
    > ===================================================================
    > --- linux-2.6.orig/include/asm-blackfin/pgtable.h
    > +++ linux-2.6/include/asm-blackfin/pgtable.h
    > @@ -59,4 +59,12 @@
    > #define VMALLOC_START 0
    > #define VMALLOC_END 0xffffffff
    >
    > +#define __HAVE_ARCH_ENTER_LAZY_CPU_MODE
    > +#define arch_enter_lazy_cpu_mode() do {} while (0)
    > +#define arch_leave_lazy_cpu_mode() do {} while (0)
    > +
    > +#define __HAVE_ARCH_ENTER_LAZY_MMU_MODE
    > +#define arch_enter_lazy_mmu_mode() do {} while (0)
    > +#define arch_leave_lazy_mmu_mode() do {} while (0)
    > +
    > #endif /* _BLACKFIN_PGTABLE_H */

    asm-generic/pgtable.h already does this if you don't explicitly define
    __HAVE_ARCH_ENTER_LAZY_{CPU,MMU}_MODE. So please kill this entirely. If
    you forgot to include asm-generic/pgtable.h, that's another matter..
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-23 07:19    [W:0.023 / U:30.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site