lkml.org 
[lkml]   [2007]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC, PATCH] SLAB : [NUMA] keep nodeid in struct page instead of struct slab
    On Wed, 21 Mar 2007 17:47:13 +0200
    "Pekka Enberg" <penberg@cs.helsinki.fi> wrote:

    > On 3/21/07, Eric Dumazet <dada1@cosmosbay.com> wrote:
    > > Last time I checked 'struct page', they was no nodeid in it.
    >
    > Hmm, page_to_nid() in include/linx/mm.h doesn't agree with you:
    >
    > #ifdef NODE_NOT_IN_PAGE_FLAGS
    > extern int page_to_nid(struct page *page);
    > #else
    > static inline int page_to_nid(struct page *page)
    > {
    > return (page->flags >> NODES_PGSHIFT) & NODES_MASK;
    > }
    > #endif
    >

    Correct, but still another ifdef NODE_NOT_IN_PAGE_FLAGS

    Anyway the correct path is to check GFP_THISNODE stuff, because we can
    even avoid access to 'struct page' to get the nodeid, at least on x86_64 NUMA,
    where struct memnode can provide the information with less cache footprint.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-21 16:57    [W:0.018 / U:340.268 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site