Messages in this thread | | | Date | Wed, 21 Mar 2007 14:44:26 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH] Turn do_sync_file_range() into do_sync_mapping_range() |
| |
On Tue, Mar 20, 2007 at 02:46:26PM -0700, Mark Fasheh wrote: > do_sync_file_range() accepts a file * from which it takes an address_space > to sync. Abstract out the bulk of the function into do_sync_mapping_range() > which takes the address_space directly. This way callers who want to sync an > address_space directly can take advantage of the functionality provided. > > do_sync_file_range() is preserved as a 3 line wrapper around > do_sync_mapping_range(). > > Ocfs2 in particular would like to use this to initiate a sync of a specific > inode range during truncate, where a file * may not be available.
Looks good to me, but I agree with Andrew that we should simply kill do_sync_file_range, espcially as at least one of the callers has file->f_mapping guaranteed != NULL;
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |