Messages in this thread | | | Date | Tue, 20 Mar 2007 23:01:43 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] swsusp: Fix SNAPSHOT_S2RAM ioctl |
| |
Hi!
> From: Rafael J. Wysocki <rjw@sisk.pl> > > The SNAPSHOT_S2RAM ioctl does not disable the nonboot CPUs before entering > the suspend, although it should do this. > > } else { > - /* Enter S3, system is already frozen */ > - suspend_enter(PM_SUSPEND_MEM); > - > + error = disable_nonboot_cpus(); > + if (!error) { > + /* Enter S3, system is already frozen */ > + suspend_enter(PM_SUSPEND_MEM); > + enable_nonboot_cpus(); > + } > /* Wake up devices */ > device_resume(); > }
Looks ok to me. ACK. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |