Messages in this thread | | | Date | Tue, 20 Mar 2007 12:43:27 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [QUICKLIST 1/5] Quicklists for page table pages V3 |
| |
On Tue, 20 Mar 2007, Paul Mackerras wrote:
> Christoph Lameter writes: > > > +static inline void *quicklist_alloc(int nr, gfp_t flags, void (*ctor)(void *)) > > +{ > > ... > > > + p = (void *)__get_free_page(flags | __GFP_ZERO); > > This will cause problems on 64-bit powerpc, at least with 4k pages, > since the pmd and pgd levels only use 1/4 of a page.
quicklists are only useful for page sized allocations. If you have smaller sizes then by all means continue the use of slab. You do not have a page struct for each pmd, pgd to do bad things with (like i386) so everything is just fine. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |