lkml.org 
[lkml]   [2007]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kthread_should_stop_check_freeze (was: Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread)
    Hi!

    > > Do not do it, then. Confusion it causes is not worth saving one line
    > > of code.
    > >
    > > You do less typing, but the resulting code is _less_ readable, not
    > > more.
    >
    > Then please document it _clearly_ with the kthread code somewhere. The
    > reason I brought this up is I had no idea we had to put the freezer gunk
    > in all kernel thread loops and Ive been writing kernel threads for years.

    This is in Doc*/power/kernel_threads.txt:

    KERNEL THREADS


    Freezer

    Upon entering a suspended state the system will freeze all
    tasks. This is done by delivering pseudosignals. This affects
    kernel threads, too. To successfully freeze a kernel thread
    the thread has to check for the pseudosignal and enter the
    refrigerator. Code to do this looks like this:

    do {
    hub_events();
    wait_event_interruptible(khubd_wait,
    !list_empty(&hub_event_list));
    try_to_freeze();
    } while (!signal_pending(current));


    ...do you know about better place?
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-20 19:11    [W:2.123 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site