Messages in this thread | | | Date | Thu, 1 Mar 2007 21:18:06 -0800 | From | Stephane Eranian <> | Subject | Re: patch 3 / 3: fix floppy mount bug in kernel 2.6.21-rc1 |
| |
Andrew,
On Thu, Mar 01, 2007 at 04:47:42PM -0800, Andrew Morton wrote: > On Thu, 01 Mar 2007 15:32:22 +0100 > "Uwe Bugla" <uwe.bugla@gmx.de> wrote: > > > Hi folks, > > this patch fixes the floppy mount bug (i. e. regression) in kernel 2.6.21-rc1. It was inspired by Stephane Eranian. It was tested on an Intel P4 1800 MHz > > (Intel ICH4 chipset) and on an AMD Athlon XP 1800 MHz (Silicon Integrated Systems chipset 740, 5513). > > My deep thanks and respect go to: > > Stephane Eranian, Linus Torvalds, Jiri Slaby. You are truthfully real men and reliable, accurate, fine chaps. It feels great to have you in this world-wide community! > > Would you still call the whole i386 architecture "a small number of machines", Mister Andrew Morton? If yes, in how far please? > > > > Signed-off-by: Uwe Bugla <uwe.bugla@gmx.de> > > > > --- a/arch/i386/kernel/process.c > > +++ b/arch/i386/kernel/process.c > > @@ -154,6 +154,7 @@ > > current_thread_info()->status |= TS_POLLING; > > } else { > > /* loop is done by the caller */ > > + local_irq_enable(); > > cpu_relax(); > > } > > } > > Linus reverted the offending patch "[PATCH] i386: add idle notifier" > on Feb 26, so this fix should no longer be needed, and 2.6.21-rc2 should > be working again. > > Hopefully Stephane will fold this fix into any future version of that patch, > if appropriate.
Well, given that nobody really liked this idle notifier, I am trying to do differently on all architectures which unfortunately is not an easy thing to do.
What I did not really like in all of this is that people come up with arguments without providing the data to prove it, e.g., increase interrupt latency (by how much?).
-- -Stephane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |