Messages in this thread | | | Subject | Re: [Fastboot] [PATCH RFC 0/5] hard_smp_processor_id overhaul | From | Fernando Luis Vázquez Cao <> | Date | Fri, 02 Mar 2007 17:06:34 +0900 |
| |
On Fri, 2007-03-02 at 09:44 +0530, Vivek Goyal wrote: > On Thu, Mar 01, 2007 at 09:06:48AM -0500, Benjamin LaHaise wrote: > > On Thu, Mar 01, 2007 at 04:16:13PM +0900, Fernando Luis Vázquez Cao wrote: > > > As a consequence, the hardcoding of hard_smp_processor_id() to 0 on UP > > > systems (see "linux/smp.h") is not correct. > > > > > > This patch-set does the following: > > > > > > 1- Remove hardcoding of hard_smp_processor_id on UP systems. > > > > NAK. This has to be configurable, as many embedded systems don't even > > have APICs. Please rework the patch set so that there is not any overhead > > for existing UP systems. > > Fernando did the code audit and found no instance of hard_smp_processor_id > being used for non APIC case. So are embedded systems you are referring, > patching the kernel? > > Anyway, I think providing hard_smp_processor_id() definition for UP systems > without APIC does not harm. Hi Vivek,
I am replying to this email with a patch that does exactly that.
Thanks, Fernando
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |