Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread | Date | Sat, 3 Mar 2007 02:03:58 +0100 |
| |
On Saturday, 3 March 2007 00:33, Oleg Nesterov wrote: > On 03/02, Paul E. McKenney wrote: > > > > One way to embed try_to_freeze() into kthread_should_stop() might be > > as follows: > > > > int kthread_should_stop(void) > > { > > if (kthread_stop_info.k == current) > > return 1; > > try_to_freeze(); > > return 0; > > } > > I think this is dangerous. For example, worker_thread() will probably > need some special actions after return from refrigerator. Also, a kernel > thread may check kthread_should_stop() in the place where try_to_freeze() > is not safe. > > Perhaps we should introduce a new helper which does this.
Agreed.
Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |