Messages in this thread | | | Date | Mon, 19 Mar 2007 10:22:11 +0100 | From | Adrian Bunk <> | Subject | sysfs_drop_dentry(): possible NULL dereference |
| |
The Coverity checker spotted the following incorrect part of commit 94bebf4d1b8e7719f0f3944c037a21cfd99a4af7:
<-- snip -->
... void sysfs_drop_dentry(struct sysfs_dirent * sd, struct dentry * parent) { struct dentry * dentry = sd->s_dentry; + struct inode *inode; if (dentry) { spin_lock(&dcache_lock); spin_lock(&dentry->d_lock); if (!(d_unhashed(dentry) && dentry->d_inode)) { + inode = dentry->d_inode; + spin_lock(&inode->i_lock); ...
<-- snip -->
If (!dentry->d_inode), then it's a NULL dereference.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |