Messages in this thread Patch in this message | | | Date | Mon, 19 Mar 2007 14:37:16 -0700 | From | Greg KH <> | Subject | [patch 02/31] Fix rtm_to_ifaddr() error return. |
| |
-stable review patch. If anyone has any objections, please let us know.
------------------
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
[IPV4]: Fix rtm_to_ifaddr() error handling.
Return negative error value (embedded in the pointer) instead of returning NULL.
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- net/ipv4/devinet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
--- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -503,8 +503,10 @@ static struct in_ifaddr *rtm_to_ifaddr(s goto errout; ifm = nlmsg_data(nlh); - if (ifm->ifa_prefixlen > 32 || tb[IFA_LOCAL] == NULL) + if (ifm->ifa_prefixlen > 32 || tb[IFA_LOCAL] == NULL) { + err = -EINVAL; goto errout; + } dev = __dev_get_by_index(ifm->ifa_index); if (dev == NULL) { -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |