lkml.org 
[lkml]   [2007]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH][2/5][resend] floppy.c: Remove pointless register keywords
Date

This patch removes the use of the 'register' keyword from floppy.c

Marking some variables 'register' may have made sense in the past (though I
doubt it for these ones), but these days I very much suspect that we would
rather grant gcc more freedom in how to handle the variables and I doubt
very much that in this day and age optimizing access to variables via
'register' makes any sense for a floppy driver. Let's just get rid of it.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 5da54b8..dea7c4f 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -791,7 +791,7 @@ static inline int is_selected(int dor, int unit)

static int set_dor(int fdc, char mask, char data)
{
- register unsigned char drive, unit, newdor, olddor;
+ unsigned char drive, unit, newdor, olddor;

if (FDCS->address == -1)
return -1;
@@ -946,7 +946,7 @@ static void motor_off_callback(unsigned long nr)
static void floppy_off(unsigned int drive)
{
unsigned long volatile delta;
- register int fdc = FDC(drive);
+ int fdc = FDC(drive);

if (!(FDCS->dor & (0x10 << UNIT(drive))))
return;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-03-19 16:13    [W:0.138 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site