lkml.org 
[lkml]   [2007]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/char/agp: Convert to generic boolean
Please use "Reply All"

Joe Perches wrote:
> On Sun, 2007-03-18 at 00:45 +0100, Richard Knutsson wrote:
>
>> diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/amd-k7-agp.c
>> index e6c534e..3d57e9f 100644
>> --- a/drivers/char/agp/amd-k7-agp.c
>> +++ b/drivers/char/agp/amd-k7-agp.c
>> @@ -308,9 +308,9 @@ static int amd_insert_memory(struct agp_memory *mem, off_t pg_start, int type)
>> j++;
>> }
>>
>> - if (mem->is_flushed == FALSE) {
>> + if (!mem->is_flushed) {
>> global_cache_flush();
>> - mem->is_flushed = TRUE;
>> + mem->is_flushed = true;
>> }
>>
>
> perhaps a generic.c / agp.h function?
>
Sound like a good idea (not in a boolean cleanup-patch thou)
Would you mind making that patch?

Richard Knutsson

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-18 02:59    [W:0.061 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site