lkml.org 
[lkml]   [2007]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kprobes: fix sparse NULL warning
On Fri, Mar 16, 2007 at 06:34:36PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix sparse NULL warnings:
> kernel/kprobes.c:915:49: warning: Using plain integer as NULL pointer

Thanks for catching this Randy.

> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>

> ---
> kernel/kprobes.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-2621-rc4.orig/kernel/kprobes.c
> +++ linux-2621-rc4/kernel/kprobes.c
> @@ -35,6 +35,7 @@
> #include <linux/hash.h>
> #include <linux/init.h>
> #include <linux/slab.h>
> +#include <linux/stddef.h>
> #include <linux/module.h>
> #include <linux/moduleloader.h>
> #include <linux/kallsyms.h>
> @@ -912,7 +913,7 @@ static int __kprobes debugfs_kprobe_init
> if (!dir)
> return -ENOMEM;
>
> - file = debugfs_create_file("list", 0444, dir , 0 ,
> + file = debugfs_create_file("list", 0444, dir, NULL,
> &debugfs_kprobes_operations);
> if (!file) {
> debugfs_remove(dir);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-17 06:41    [W:2.635 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site