lkml.org 
[lkml]   [2007]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 6/13] signalfd/timerfd/asyncfd v5 - timerfd core ...
From
Date
On Thu, 2007-03-15 at 16:02 -0700, Davide Libenzi wrote:
> > > + /*
> > > + * When we call this, the initialization must be complete, since
> > > + * aino_getfd() will install the fd.
> > > + */
> > > + error = aino_getfd(&ufd, &inode, &file, "[timerfd]",
> > > + &timerfd_fops, ctx);
> > > + if (error)
> > > + goto err_ctxfree;
> >
> > Again: Please turn this around. No need to start the timer before we
> > know, that everything works.
>
> The timerfd_setup() is not locked, so we need to make sure everything is
> setup, before advertising the fd (and aino_getfd does that).

Right. Did not think about the bad boys peeking at file descriptors :)

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-16 08:43    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site