Messages in this thread | | | Date | Fri, 16 Mar 2007 10:02:23 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [patch 21/26] Xen-paravirt_ops: Use the hvc console infrastructure for Xen console |
| |
Ingo Molnar wrote: >> + prod = intf->in_prod; >> + mb(); >> + BUG_ON((prod - cons) > sizeof(intf->in)); >> > > such mb()'s are typically a sign of "i have no clear idea what SMP > serialization rules apply here, but something is needed because > otherwise it breaks" ?
Hm, in this case its because it's sharing the memory with Xen, so there's a particular ordering protocol. It needs some comments.
J
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |