Messages in this thread Patch in this message | | | Date | Fri, 16 Mar 2007 13:38:24 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH 4/5] AF_RXRPC: Key facility changes for AF_RXRPC [try #2] |
| |
On Fri, Mar 16, 2007 at 12:50:31PM +0000, David Howells wrote: > Export the keyring key type definition. > > Add extra alternative types into the key's type_data union to make it more > useful.
You wrote the code so there must be some reason for this, but these changes look rather odd to me :)
> diff --git a/security/keys/keyring.c b/security/keys/keyring.c > index ad45ce7..88292e3 100644 > --- a/security/keys/keyring.c > +++ b/security/keys/keyring.c > @@ -66,6 +66,8 @@ struct key_type key_type_keyring = { > .read = keyring_read, > }; > > +EXPORT_SYMBOL(key_type_keyring); > +
Having a type exported is really odd, how is this supposed to be a public API? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |