Messages in this thread | | | Date | Wed, 14 Mar 2007 19:18:16 -0700 | From | Jeremy Fitzhardinge <> | Subject | Geode cs5530a magic (Was: Re: [PATCH] clean up mach_reboot_fixups) |
| |
Andi Kleen wrote: > On Wednesday 14 March 2007 23:24, Jeremy Fitzhardinge wrote: > >> The reboot_fixups stuff seems to be a bit of a mess, specifically the >> header is in linux/ when its a purely i386-specific piece of code. I'm >> not sure why it has its config option; its only currently needed for >> "geode-gx1/cs5530a", so perhaps whatever config option controls that >> hardware should enable this? >> > > Thanks. Looks good.
It looks like a cs5530a is a PATA driver in drivers/ata/pata_cs5530.c. Seems to me the cleanest fix is to register a reboot notifier in the driver and have it do the magic rather than have the special mach_reboot_fixups mechanism at all.
Assuming it needs to be done at all...
Alan? Jaya?
J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |