lkml.org 
[lkml]   [2007]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 13/13] fix ps3fb glue allowing a modular build
    On Wed, 14 Mar 2007, Linus Torvalds wrote:
    > On Wed, 14 Mar 2007, Al Viro wrote:
    > > Nope. How can kconfig distinguish that from a boolean option in modular
    > > driver? bool *can* depend on tristate and be selected when tristate is
    > > set to m.
    >
    > Btw, this is one of those things that easily causes problems.

    I just found another caveat: while `select' is some super-override-it-all that
    ignores depends on non-existent symbols, it doesn't promote `m' to `y'.
    E.g. `select FB_CFB_FILLRECT' from a bool still gives FB_CFB_FILLRECT=m if
    FB=m.

    Anyway, here's a fix for the 3 problematic cases I found.

    Subject: bool fbdevs must depend on FB = y

    Frame buffer device drivers that cannot be built as modules must depend on
    `FB = y'. Correct the 3 remaining offenders.

    Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>

    diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
    index 7f5a598..e4f0dd0 100644
    --- a/drivers/video/Kconfig
    +++ b/drivers/video/Kconfig
    @@ -1320,7 +1320,7 @@ config FB_AU1100

    config FB_AU1200
    bool "Au1200 LCD Driver"
    - depends on FB && MIPS && SOC_AU1200
    + depends on (FB = y) && MIPS && SOC_AU1200
    select FB_CFB_FILLRECT
    select FB_CFB_COPYAREA
    select FB_CFB_IMAGEBLIT
    @@ -1470,7 +1470,7 @@ config FB_G364

    config FB_68328
    bool "Motorola 68328 native frame buffer support"
    - depends on FB && (M68328 || M68EZ328 || M68VZ328)
    + depends on (FB = y) && (M68328 || M68EZ328 || M68VZ328)
    select FB_CFB_FILLRECT
    select FB_CFB_COPYAREA
    select FB_CFB_IMAGEBLIT
    @@ -1616,7 +1616,7 @@ config FB_IBM_GXT4500

    config FB_PS3
    bool "PS3 GPU framebuffer driver"
    - depends on FB && PS3_PS3AV
    + depends on (FB = y) && PS3_PS3AV
    select FB_CFB_FILLRECT
    select FB_CFB_COPYAREA
    select FB_CFB_IMAGEBLIT
    Gr{oetje,eeting}s,
    Geert

    --
    Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
    Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
    Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-03-14 18:47    [W:0.041 / U:1.840 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site