Messages in this thread | | | Subject | Re: [PATCH] BUILD_BUG_ON_ZERO -> BUILD_BUG_OR_ZERO | From | Rusty Russell <> | Date | Tue, 13 Mar 2007 09:25:03 +1100 |
| |
On Mon, 2007-03-12 at 15:14 +0100, Stefan Richter wrote: > Robert P. J. Day wrote: > > On Mon, 12 Mar 2007, Stefan Richter wrote: > >> Rusty Russell wrote: > >> > OTOH, BUILD_BUG_OR_ZERO says what happens: either it's a build bug, or > >> > it's zero. > >> > >> What about ZERO_UNLESS_BUILD_BUG_ON(e)? It's long though... > > > > how often is this going to be used? it's not like the tree is > > currently awash in calls to BUILD_BUG_ON_ZERO as it is. > > Most of the time it will hidden as a macro-in-a-macro, like in > ARRAY_SIZE(). So the length of the name doesn't matter much. But then, > the _name_ itself doesn't matter much because authors of public macros > are the primary user group, not John Driverhacker.
Well, there's a four line comment above it, so *someone* thought it worth documenting. Even if the new name isn't great, the old name is actively misleading. That's a 13, and we could be a 4.
http://ozlabs.org/~rusty/ols-2003-keynote/img52.html
Cheers, Rusty.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |