lkml.org 
[lkml]   [2007]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: refcounting drivers' data structures used in sysfs buffers
    Date
    Am Montag, 12. März 2007 17:21 schrieb Alan Stern:
    > On Mon, 12 Mar 2007, Oliver Neukum wrote:
    >
    > > > > Yes, I was missing the point. In consequence, drivers must not use
    > > > > dev_get_drvdata() to get their references to their private data. It's
    >
    > You do realize how foolish that sounds? Why do you think
    > dev_get_drvdata() was written in the first place?

    It's still useful in disconnect/suspend/resume/etc...
    If everything were alright with the design, we wouldn't be discussing
    it now, would we?


    > I'm with Dmitry; the whole thing becomes much, much simpler if we put back
    > your patch and prevent sysfs access after unregistering an attribute
    > file. No API changes are needed, no driver changes are needed, no radical
    > core changes are needed,... All we would have to do is fix the one SCSI
    > method to make it use a workqueue.

    Try. I don't like reverting my own code. But I predict he'll tell you that a
    driver's bond with a device should be represented in a data structure
    that is to be refcounted.

    Regards
    Oliver
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-12 19:29    [W:3.800 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site