Messages in this thread Patch in this message | | | Date | Mon, 12 Mar 2007 12:04:30 +0100 | From | Takashi Iwai <> | Subject | Re: [SOUND] hda_intel: build fix |
| |
At Sat, 10 Mar 2007 19:05:13 +0000, Ralf Baechle wrote: > > CC [M] sound/pci/hda/hda_intel.o > sound/pci/hda/hda_intel.c:1508: error: position_fix_list causes a section type conflict > > Gcc like its __devinitdata readable not const, it seems. An alternative > fix would be to remove the __devinitdata attribute but that would result > in slight runtime bloat. > > Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
It's no big problem to remove const in these cases, but allowing const with __devinitdata seems the right fix to me...
Takashi
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index b9a8e23..63b6854 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -1505,7 +1505,7 @@ static int azx_dev_free(struct snd_device *device) > /* > * white/black-listing for position_fix > */ > -static const struct snd_pci_quirk position_fix_list[] __devinitdata = { > +static struct snd_pci_quirk position_fix_list[] __devinitdata = { > SND_PCI_QUIRK(0x1028, 0x01cc, "Dell D820", POS_FIX_NONE), > {} > }; > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |