lkml.org 
[lkml]   [2007]   [Mar]   [11]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 10 Mar 2007 23:26:10 -0800
FromAndrew Morton <>
SubjectRe: [PATCH] CIRRUS: Delete unused header file.
> On Sat, 10 Mar 2007 17:27:44 -0500 (EST) "Robert P. J. Day" <rpjday@mindspring.com> wrote:
> 
>   Delete apparently unused header file
> sound/pci/cs46xx/imgs/cwcemb80.h.
> 

That patch series was rather a mess

- Multiple patches with the same Subject: (I might have lost some as a result)

- Several patches which tried to remove the same header file

- Several patches which simply didn't apply

- Inconsisent changelogging, inconsistent titling

- Lack of sequence numbering (again, contributes to possible patch loss)

- Useless indenting in changleog text which I have to edit away.

We have good tools (ie: quilt) which make this sort of thing nice and easy
to get right - please use them.

I didn't check that these headers are indeed unused.  I hope you got that
minor part right..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-11 08:29    [from the cache]
©2003-2008