[lkml]   [2007]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] md: Fix for raid6 reshape.
    ### Comments for Changeset

    Recent patch for raid6 reshape had a change missing that showed up in
    subsequent review.

    Many places in the raid5 code used "conf->raid_disks-1" to mean
    "number of data disks". With raid6 that had to be changed to
    "conf->raid_disk - conf->max_degraded" or similar. One place was missed.

    This bug means that if a raid6 reshape were aborted in the middle the
    recorded position would be wrong. On restart it would either fail (as
    the position wasn't on an appropriate boundary) or would leave a section
    of the array unreshaped, causing data corruption.

    Signed-off-by: Neil Brown <>

    ### Diffstat output
    ./drivers/md/raid5.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff .prev/drivers/md/raid5.c ./drivers/md/raid5.c
    --- .prev/drivers/md/raid5.c 2007-03-02 15:47:51.000000000 +1100
    +++ ./drivers/md/raid5.c 2007-03-02 15:48:35.000000000 +1100
    @@ -3071,7 +3071,7 @@ static sector_t reshape_request(mddev_t
    - conf->expand_progress = (sector_nr + i)*(conf->raid_disks-1);
    + conf->expand_progress = (sector_nr + i) * new_data_disks);
    /* Ok, those stripe are ready. We can start scheduling
    * reads on the source stripes.
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at
     \ /
      Last update: 2007-03-02 06:01    [W:0.018 / U:48.272 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site