[lkml]   [2007]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Subject[PATCH 000 of 3] knfsd: Resolve IPv6 related link error
    Current mainline has a compile linkage problem if both

    because net/sunrpc/svcsock.c conditionally used a function defined in the IPv6 module.

    These three patches resolve the issue.

    The problem is caused because svcsock needs to get the source and
    destination address for a udp packet, but doesn't want to just use
    sock_recvmsg like userspace would as it wants to be able to use the
    data directly out of the skbuff rather than copying it (when practical).

    Currently it copies code from udp.c (both ipv4/ and ipv6/) and this
    causes the problem.

    This patch changes it to use kernel_recvmsg with a length of 0 and
    flags of MSG_PEEK to get the addresses but leave the data untouched.

    A small problem here is that kernel_recvmsg always checks the
    checksum, so in the case of a large packet we will check the checksum
    at a different time to when we copy it out into a buffer, which is not ideal.

    So the second patch of this series avoids the check when recv_msg is
    called with size==0 and flags==MSG_PEEK. This change should be acked
    by someone on netdev before going upsteam!!! The rest of the series
    is still appropriate without the patch, it is just a small

    Finally the last patch removes all the
    #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
    from sunrpc as it really isn't needed and just hides this sort of problem.

    Patches 1 and 3 are suitable for 2.6.21. Patch 2 needs confirmation.


    [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying
    [PATCH 002 of 3] knfsd: Avoid checksum checks when collecting metadata for a UDP packet.
    [PATCH 003 of 3] knfsd: Remove CONFIG_IPV6 ifdefs from sunrpc server code.
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-03-02 05:33    [W:0.020 / U:153.960 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site