Messages in this thread | | | Date | 9 Feb 2007 12:57:58 +0100 | Date | Fri, 9 Feb 2007 12:57:58 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 6/10] lguest code: the little linux hypervisor. |
| |
On Fri, Feb 09, 2007 at 03:54:37AM -0800, Zachary Amsden wrote: > Andi Kleen wrote: > >>Yes, it is a bit, umm, innovative. If it is going to be kept, even if > >>just for devel logging, you should disable interrupts around it. > >>Changing segments is not a normal thing to do. > >> > > > >Actually that wouldn't be needed because interrupts are not allowed to do > >any user accesses. And contrary to the name it doesn't actually change > >the segment registers, only state used by *_user. > > > > My bad, I fell for the same mistake as everyone. Set_fs is just way too
You could change the name. Only 654 occurrences all over the tree @)
> confusing of a name now. But good to know interrupts must be disable in > such a circumstance.
+not
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |