Messages in this thread | | | Date | Fri, 9 Feb 2007 12:35:04 +0100 (CET) | From | Roman Zippel <> | Subject | Re: The who needs reviews anyways [PATCH] |
| |
Hi,
On Fri, 9 Feb 2007, Oleg Verych wrote:
> > - else if [ -x /bin/bash ]; then echo /bin/bash; \ > > - else echo sh; fi ; fi) > > + else if [ -x /bin/bash ]; then echo /bin/bash; fi; fi) > > +ifeq ($(CONFIG_SHELL),) > > +$(error bash is required to build the kernel) > > +endif > > +SHELL := $(CONFIG_SHELL) > > here is policy to have `bash' introduced, so due to original > issue, where `root' users ended with removed /dev/null, may policy to have > `non root' user to build kernel be added? Thus
I doubt gentoo user will like you for that and above is more a de facto requirement that bash is needed for kbuild. The alternative is to introduce a new policy that everything is POSIX clean.
> this: > > + rm -f "$$TMP") > > may be removed, and to make TMP=/dev/null? And to forget currently about > my silly symlinks, and this crappy sets of output files?
This still wouldn't work, as these tests are also done when running 'make install'.
> > -as-instr = $(call checker-shell,\ > > - printf "$(1)" | $(CC) $(AFLAGS) -c -xassembler -o $$OUT -,$(2),$(3)) > > `printf $(1)' is pretty enough.
As Andreas suggested 'printf "%b" "$(1)"' would be the other alternative.
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |