Messages in this thread | | | Date | Fri, 9 Feb 2007 09:39:32 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: Fw: [BUG][PATCH] fix mempolcy's check on a system with memory-less-node take3 |
| |
On Thu, 8 Feb 2007 11:28:30 -0800 (PST) Christoph Lameter <clameter@sgi.com> wrote: > > @@ -193,9 +197,11 @@ > > break; > > case MPOL_BIND: > > policy->v.zonelist = bind_zonelist(nodes); > > - if (policy->v.zonelist == NULL) { > > + if (IS_ERR(policy->v.zonelist)) { > > + void *val = policy->v.zonelist; > > + policy->v.zonelist = NULL; > > void *? Ahh. It takes the error code. > > Looks good. But if we are really going down this road of memory-less > nodes we may want to audit the kernel for other issues. > > Could you run a series of tests on that machine? > Yes. The program which caused trouble works fine. I used 'numademo' command in numactl package. It works fine (reports -EINVAL) with this patch now.
I uses this a system with an empty-node for 5 months. reported 2 bugs. - oom-kill's memory less node detection logic. - mempolicy's NULL access(this)
It works fine in general. (old RHEL4/linux-2.6.9 kernel doesn't boot on this system.)
-Kame
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |