lkml.org 
[lkml]   [2007]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2/3] smaps: add pages referenced count to smaps
On Tue, 6 Feb 2007, Andrew Morton wrote:

> > @@ -190,18 +191,20 @@ static int show_map_internal(struct seq_file *m, void *v, struct mem_size_stats
> >
> > if (mss)
> > seq_printf(m,
> > - "Size: %8lu kB\n"
> > - "Rss: %8lu kB\n"
> > - "Shared_Clean: %8lu kB\n"
> > - "Shared_Dirty: %8lu kB\n"
> > - "Private_Clean: %8lu kB\n"
> > - "Private_Dirty: %8lu kB\n",
> > + "Size: %8lu kB\n"
> > + "Rss: %8lu kB\n"
> > + "Shared_Clean: %8lu kB\n"
> > + "Shared_Dirty: %8lu kB\n"
> > + "Private_Clean: %8lu kB\n"
> > + "Private_Dirty: %8lu kB\n"
> > + "Pgs_Referenced: %8li\n",
>
> I guess we might as well make this %8lu kB as well?
>

Ah, %8lu would work since it's a count of pages and not a size.

> This is testing the software-referenced bit. We want to be counting the
> pte-referenced bits (pte_young).
>
> Hence poking clear_refs should run pte_mkold().
>
> Perhaps we should also be running ClearPageReferenced and counting pages
> which are pte_young()||PageReferenced.
>

Ok.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-07 06:59    [W:0.092 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site