lkml.org 
[lkml]   [2007]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] rcutorture: Remove redundant assignment to cur_ops in for loop
    Josh Triplett wrote:
    > The for loop in rcutorture_init uses the condition
    > cur_ops = torture_ops[i], cur_ops
    > but then makes the same assignment to cur_ops inside the loop. Remove the
    > redundant assignment inside the loop, and remove now-unnecessary braces.
    >
    > Signed-off-by: Josh Triplett <josh@kernel.org>
    > ---
    > kernel/rcutorture.c | 7 ++-----
    > 1 files changed, 2 insertions(+), 5 deletions(-)
    >
    > diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
    > index 0c7bf0c..7258bcb 100644
    > --- a/kernel/rcutorture.c
    > +++ b/kernel/rcutorture.c
    > @@ -875,12 +875,9 @@ rcu_torture_init(void)
    >
    > /* Process args and tell the world that the torturer is on the job. */
    >
    > - for (i = 0; cur_ops = torture_ops[i], cur_ops; i++) {
    > - cur_ops = torture_ops[i];
    > - if (strcmp(torture_type, cur_ops->name) == 0) {
    > + for (i = 0; cur_ops = torture_ops[i], cur_ops; i++)
    >
    May be tired right now, but wouldn't it be more logical with:

    for (i = 0; cur_ops = torture_ops[i], i++)

    Right now it seems to have two conditions for cur_ops.


    Just my 2cent
    Richard Knutsson


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-08 01:01    [W:0.020 / U:0.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site