lkml.org 
[lkml]   [2007]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2.6.20] isdn-capi: Use ARRAY_SIZE macro when appropriate
    From
    Date
    On Tue, 2007-02-06 at 18:04 +0200, Ahmed S. Darwish wrote:
    > A patch to use ARRAY_SIZE macro already defined in kernel.h
    > Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
    > ---
    > diff --git a/drivers/isdn/capi/capi.c b/drivers/isdn/capi/capi.c
    > index d22c022..3804591 100644
    > --- a/drivers/isdn/capi/capi.c
    > +++ b/drivers/isdn/capi/capi.c
    > @@ -1456,7 +1456,7 @@ static struct procfsentries {
    >
    > static void __init proc_init(void)
    > {
    > - int nelem = sizeof(procfsentries)/sizeof(procfsentries[0]);
    > + int nelem = ARRAY_SIZE(procfsentries);
    > int i;
    >
    > for (i=0; i < nelem; i++) {

    For these patches, perhaps you can eliminate the temporary
    variable and change the loop to the more common form of

    for (i = 0; i < ARRAY_SIZE(array); i++) {


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-06 18:55    [W:0.020 / U:0.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site