lkml.org 
[lkml]   [2007]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 0/28] Patches to pass vfsmount to LSM inode security hooks
    * Trond Myklebust (trond.myklebust@fys.uio.no) wrote:
    > On Mon, 2007-02-05 at 18:44 +0000, Christoph Hellwig wrote:
    > > Just FYI: Al was very opposed to the idea of passing the vfsmount to
    > > the vfs_ helpers, so you should discuss this with him.
    > >
    > > Looking at the actual patches I see you're lazy in a lot of places.
    > > Please make sure that when you introduce a vfsmount argument somewhere
    > > that it is _always_ passed and not just when it's conveniant. Yes, that's
    > > more work, but then again if you're not consistant anyone half-serious
    > > will laught at a security model using this infrasturcture.
    >
    > nfsd in particular tends to be a bit lazy about passing around vfsmount
    > info. Forcing it to do so should not be hard since the vfsmount is
    > already cached in the "struct export" (which can be found using the
    > filehandle). It will take a bit of re-engineering in order to pass that
    > information around inside the nfsd code, though.

    Yeah, last time I looked at that it was always available, just a bit ugly
    to go digging for the vfsmount.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-05 20:11    [W:0.022 / U:34.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site