[lkml]   [2007]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] Missing critical phys_to_virt in lib/swiotlb.c
    From: David Moore <>

    Adds missing call to phys_to_virt() in the
    lib/swiotlb.c:swiotlb_sync_sg() function. Without this change, a kernel
    panic will always occur whenever a SWIOTLB bounce buffer from a
    scatter-gather list gets synced.

    Signed-off-by: David Moore <>

    This change was originally part of a larger patch by Jan Beulich, which
    was more extensive and doesn't look destined to make it into 2.6.20:

    However, considering the severity of this one-liner bug, I would like to
    request that this simplified patch make it into 2.6.20, despite how
    close we are to the final cut. It fixes real crashes:

    --- linux-2.6.19.x86_64/lib/swiotlb.c.orig 2007-02-04 13:18:41.000000000 -0500
    +++ linux-2.6.19.x86_64/lib/swiotlb.c 2007-02-04 13:19:43.000000000 -0500
    @@ -750,7 +750,7 @@ swiotlb_sync_sg(struct device *hwdev, st

    for (i = 0; i < nelems; i++, sg++)
    if (sg->dma_address != SG_ENT_PHYS_ADDRESS(sg))
    - sync_single(hwdev, (void *) sg->dma_address,
    + sync_single(hwdev, phys_to_virt(sg->dma_address),
    sg->dma_length, dir, target);

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-02-04 19:43    [W:3.259 / U:0.172 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site