lkml.org 
[lkml]   [2007]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 1/9] fs: libfs buffered write leak fix
    On Sat, 3 February 2007 02:33:16 +0100, Nick Piggin wrote:
    >
    > If doing a partial-write, simply clear the whole page and set it uptodate
    > (don't need to get too tricky).

    That sounds just like a bug I recently fixed in logfs. prepare_write()
    would clear the page, commit_write() would write the whole page. Bug
    can be reproduced with a simple testcate:

    echo -n foo > foo
    echo -n bar >> foo
    cat foo

    With the bug, the second write will replace "foo" with "\0\0\0" and
    cat will return "bar". Doing a read instead of clearing the page will
    return "foobar", as would be expected.

    Can you hit the same bug with your patch or did I miss something?

    Jörn

    --
    When people work hard for you for a pat on the back, you've got
    to give them that pat.
    -- Robert Heinlein
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-03 18:57    [W:0.021 / U:1.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site