[lkml]   [2007]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] drivers/isdn/gigaset: new M101 driver
    On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote:
    > > +/* dummy to shut up framework warning */
    > > +static void gigaset_device_release(struct device *dev)
    > > +{
    > > + //FIXME anything to do? cf. platform_device_release()
    > > +}
    > Ask Greg ;)

    Oh come on people. Don't provide an empty function because the kernel
    is complaining that you don't provide a release function. Yes it will
    shut the kernel up but did you ever think _why_ the kernel was
    complaining? Did you think it did it just for fun?

    Think people, think...

    You need to free your memory here, don't just provide an empty function,
    that shows the driver is broken.


    greg k-h
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-02-03 17:13    [W:0.018 / U:7.648 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site