Messages in this thread | | | Subject | Re: [patch 04/26] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries | From | Rusty Russell <> | Date | Thu, 01 Mar 2007 08:02:50 +1100 |
| |
On Wed, 2007-02-28 at 09:32 +0100, Ingo Molnar wrote: > * Jeremy Fitzhardinge <jeremy@goop.org> wrote: > > > >> +#ifdef CONFIG_PARAVIRT > > >> +/* After pte_t, etc, have been defined */ > > >> +#include <asm/paravirt.h> > > >> +#endif > > >> > > > > > > hm - there's already a CONFIG_PARAVIRT conditional in > > > asm-i386/paravirt.h. > > > > Yes, but it happens after asm/paravirt.h has already included some > > things, and it ends up causing problems. paravirt.h still defines > > various stub functions in the !CONFIG_PARAVIRT case, so it needs to do > > the includes either way. > > hm, it then needs to be fixed first, instead of adding to the mess.
Yes, originally paravirt.h didn't define anything if !CONFIG_PARAVIRT for this reason: getting it tied into the other headers correctly is a PITA.
Rusty.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |