lkml.org 
[lkml]   [2007]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm 2/6] Freezer: Fix memory ordering in refrigerator
    On 02/26, Rafael J. Wysocki wrote:
    >
    > From: Oleg Nesterov <oleg@tv-sign.ru>
    >
    > refrigerator() can miss a wakeup, "wait event" loop needs a proper memory
    > ordering.
    >
    > Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
    > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    > Acked-by: Pavel Machek <pavel@ucw.cz>
    > ---
    > kernel/power/process.c | 6 ++++--
    > 1 file changed, 4 insertions(+), 2 deletions(-)
    >
    > Index: linux-2.6.20-mm2/kernel/power/process.c
    > ===================================================================
    > --- linux-2.6.20-mm2.orig/kernel/power/process.c
    > +++ linux-2.6.20-mm2/kernel/power/process.c
    > @@ -47,8 +47,10 @@ void refrigerator(void)
    > recalc_sigpending(); /* We sent fake signal, clean it up */
    > spin_unlock_irq(&current->sighand->siglock);
    >
    > - while (frozen(current)) {
    > - current->state = TASK_UNINTERRUPTIBLE;
    > + for (;;) {
    > + set_current_state(TASK_UNINTERRUPTIBLE);
    > + if (!frozen(current))
    > + break;
    > schedule();
    > }
    > pr_debug("%s left refrigerator\n", current->comm);

    This one is already in -mm tree.

    Oleg.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-26 12:35    [W:0.024 / U:0.868 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site