Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [RFC][PATCH 1/3] Freezer: Fix vfork problem | Date | Mon, 26 Feb 2007 19:28:18 +0100 |
| |
On Monday, 26 February 2007 17:11, Oleg Nesterov wrote: > On 02/26, Srivatsa Vaddagiri wrote: > > > > On Mon, Feb 26, 2007 at 03:00:43PM +0300, Oleg Nesterov wrote: > > > In that case we should also modify ____call_usermodehelper(), otherwise we have > > > the same "deadlock" if it is frozen. But this is not so easy to do as I thought > > > before. > > > > Before ____call_usermodehelper can freeze, it should have entered userspace > > right? By that time, its vfork parent should have definitely woken up, > > which should avoid the deadlock you point out? > > Ah, yes, thanks for correcting me. > > We are doing flush_old_exec() a way before entering userspace of course.
Well, does it mean the patch is acceptable or should I modify it somehow?
Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |